From 1aa4fefe7336a6608e4c8d5b4696b44160ec7ca0 Mon Sep 17 00:00:00 2001 From: Jeremy Wiebe Date: Fri, 20 Dec 2024 10:08:42 -0800 Subject: [PATCH] Update changesets' auto-commit feature to not suppress CI on commits (#2409) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary: I recently updated our Changesets config to auto-commit the `.md` file when using `yarn changset` to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds `[skip ci]` to the commit created when running `yarn changesets version`. No CI on that PR/commit, meant that none of our release Github Actions ran! So this PR fixes the config so that Changesets no longer adds `[skip ci]` to any commits, but still auto-commits them. Issue: "none" ## Test plan: Land this PR Merge `main` into an open Version Packages PR Land that PR and ensure the release goes out Author: jeremywiebe Reviewers: jandrade Required Reviewers: Approved By: jandrade Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ⏭️ dependabot, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: https://github.com/Khan/wonder-blocks/pull/2409 --- .changeset/config.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/config.json b/.changeset/config.json index 5ade926a5..87e1855a9 100644 --- a/.changeset/config.json +++ b/.changeset/config.json @@ -1,7 +1,7 @@ { - "$schema": "https://unpkg.com/@changesets/config@1.6.2/schema.json", + "$schema": "https://unpkg.com/@changesets/config@2/schema.json", "changelog": "@changesets/cli/changelog", - "commit": true, + "commit": ["@changesets/cli/commit", { "skipCI": false }], "linked": [], "access": "public", "baseBranch": "main",