From 40d2ebb75fdadfb361330236e0fb9e54a32d0fc2 Mon Sep 17 00:00:00 2001
From: Jeremy Wiebe <jeremy@khanacademy.org>
Date: Thu, 21 Nov 2024 15:18:11 -0800
Subject: [PATCH] Numeric-Input: Extract validation from scorer (#1882)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Summary:

This PR extracts validation from the `numeric-input`'s scorer function. In reality, it's an empty function, but it follows our conventions for having the scorer call a validator first. I've created the standard tests to ensure that scorer calls the validator.

Issue: LEMS-2607

## Test plan:

`yarn test`
`yarn typecheck`

Author: jeremywiebe

Reviewers: handeyeco, jeremywiebe, Myranae

Required Reviewers:

Approved By: handeyeco

Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ gerald, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/1882
---
 .changeset/honest-avocados-accept.md          |  5 +++++
 .../numeric-input/score-numeric-input.test.ts | 20 +++++++++----------
 .../numeric-input/score-numeric-input.ts      |  2 +-
 3 files changed, 16 insertions(+), 11 deletions(-)
 create mode 100644 .changeset/honest-avocados-accept.md

diff --git a/.changeset/honest-avocados-accept.md b/.changeset/honest-avocados-accept.md
new file mode 100644
index 0000000000..4d7d3129cf
--- /dev/null
+++ b/.changeset/honest-avocados-accept.md
@@ -0,0 +1,5 @@
+---
+"@khanacademy/perseus": minor
+---
+
+Introduces a validation function for the numeric-input widget (extracted from numeric-input scoring function).
diff --git a/packages/perseus/src/widgets/numeric-input/score-numeric-input.test.ts b/packages/perseus/src/widgets/numeric-input/score-numeric-input.test.ts
index c6ee90ec2c..de2a226656 100644
--- a/packages/perseus/src/widgets/numeric-input/score-numeric-input.test.ts
+++ b/packages/perseus/src/widgets/numeric-input/score-numeric-input.test.ts
@@ -28,11 +28,11 @@ describe("static function validate", () => {
             coefficient: true,
         };
 
-        const useInput = {
+        const userInput = {
             currentValue: "1",
         } as const;
 
-        const score = scoreNumericInput(useInput, rubric, mockStrings);
+        const score = scoreNumericInput(userInput, rubric, mockStrings);
 
         expect(score).toHaveBeenAnsweredCorrectly();
     });
@@ -52,11 +52,11 @@ describe("static function validate", () => {
             coefficient: true,
         };
 
-        const useInput = {
+        const userInput = {
             currentValue: "sadasdfas",
         } as const;
 
-        const score = scoreNumericInput(useInput, rubric, mockStrings);
+        const score = scoreNumericInput(userInput, rubric, mockStrings);
 
         expect(score).toHaveInvalidInput(
             "We could not understand your answer. Please check your answer for extra text or symbols.",
@@ -143,11 +143,11 @@ describe("static function validate", () => {
             coefficient: true,
         };
 
-        const useInput = {
+        const userInput = {
             currentValue: "1.0",
         } as const;
 
-        const score = scoreNumericInput(useInput, rubric, mockStrings);
+        const score = scoreNumericInput(userInput, rubric, mockStrings);
 
         expect(score).toHaveBeenAnsweredCorrectly();
     });
@@ -167,11 +167,11 @@ describe("static function validate", () => {
             coefficient: true,
         };
 
-        const useInput = {
+        const userInput = {
             currentValue: "1.3",
         } as const;
 
-        const score = scoreNumericInput(useInput, rubric, mockStrings);
+        const score = scoreNumericInput(userInput, rubric, mockStrings);
 
         expect(score).toHaveBeenAnsweredIncorrectly();
     });
@@ -191,11 +191,11 @@ describe("static function validate", () => {
             coefficient: true,
         };
 
-        const useInput = {
+        const userInput = {
             currentValue: "1.12",
         } as const;
 
-        const score = scoreNumericInput(useInput, rubric, mockStrings);
+        const score = scoreNumericInput(userInput, rubric, mockStrings);
 
         expect(score).toHaveBeenAnsweredCorrectly();
     });
diff --git a/packages/perseus/src/widgets/numeric-input/score-numeric-input.ts b/packages/perseus/src/widgets/numeric-input/score-numeric-input.ts
index 46a98eaf12..d4637185ec 100644
--- a/packages/perseus/src/widgets/numeric-input/score-numeric-input.ts
+++ b/packages/perseus/src/widgets/numeric-input/score-numeric-input.ts
@@ -61,7 +61,7 @@ export function maybeParsePercentInput(
         return value / 100;
     }
 
-    // Otherwise, we return input valuåe (number) stripped of the "%".
+    // Otherwise, we return input value (number) stripped of the "%".
     return value;
 }