From 0587dc04b770524cce8c603fcd90e7c25844be46 Mon Sep 17 00:00:00 2001 From: Matthew Date: Wed, 23 Oct 2024 15:32:32 -0500 Subject: [PATCH] Remove isMobile from Dependencies (#1789) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary: Remove isMobile from Dependencies since it's now on APIOptions Author: handeyeco Reviewers: mark-fitzgerald, jeremywiebe Required Reviewers: Approved By: mark-fitzgerald Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: https://github.com/Khan/perseus/pull/1789 --- .changeset/smart-phones-rush.md | 5 +++++ packages/perseus/src/types.ts | 1 - testing/test-dependencies.tsx | 1 - 3 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 .changeset/smart-phones-rush.md diff --git a/.changeset/smart-phones-rush.md b/.changeset/smart-phones-rush.md new file mode 100644 index 0000000000..958a2ca633 --- /dev/null +++ b/.changeset/smart-phones-rush.md @@ -0,0 +1,5 @@ +--- +"@khanacademy/perseus": patch +--- + +Remove isMobile from Dependencies since it's now on APIOptions diff --git a/packages/perseus/src/types.ts b/packages/perseus/src/types.ts index 7d40aa839f..7f23d9f9fd 100644 --- a/packages/perseus/src/types.ts +++ b/packages/perseus/src/types.ts @@ -496,7 +496,6 @@ export type PerseusDependencies = { // RequestInfo isDevServer: boolean; kaLocale: string; - isMobile: boolean; }; /** diff --git a/testing/test-dependencies.tsx b/testing/test-dependencies.tsx index be41efc493..96efb8a8eb 100644 --- a/testing/test-dependencies.tsx +++ b/testing/test-dependencies.tsx @@ -103,7 +103,6 @@ export const testDependencies: PerseusDependencies = { isDevServer: false, kaLocale: "en", - isMobile: false, Log: LogForTesting, };