Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for ERC20 approvals to be displayed in decimal rather than hex #467

Open
plasmacorral opened this issue Jan 4, 2024 · 0 comments

Comments

@plasmacorral
Copy link

plasmacorral commented Jan 4, 2024

When signing a spending approval on an ERC20, the details tab will represent the approval amount in hex. This could be more clear for users if this value was displayed in decimal.

In the attached screenshot, I submitted and approval for 1.2345 on a 4 decimal ERC20 that I had deployed on a testnet. However, in firmware 1.2.4 on hardware v3 this value was shown as 3039.

DetailsInput

Reproduction steps:

  1. Setup Keystone v3
  2. Bind to MetaMask (v11.7.2 tested with Chrome 117.0.5938.92)
  3. Select Keystone address as active
  4. Be on testnet
  5. Go to test dapp
  6. Connect
  7. Scroll down to Send tokens section and tap CREATE TOKEN
  8. Once confirmed, Add it to wallet with ADD TOKEN(S) TO WALLET
  9. tap APPROVE TOKENS cta in test dapp
  10. edit the amount if you chose
  11. Tap Next in MetaMask
  12. Tap Approve in MetaMask
  13. Open MetaMask again bc open issue
  14. Scan QR with Keystone
  15. Tap details tab and scroll down
@plasmacorral plasmacorral changed the title Request for ERC20 approvals to be denoted in decimal rather than hex Request for ERC20 approvals to be displayed in decimal rather than hex Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant