Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental releases don't have proper versioning for Release Candidate #12

Open
doebrowsk opened this issue Oct 25, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@doebrowsk
Copy link
Contributor

Starting a new incremental release on an existing release branch is not setting the Release Candidate version correctly.

1.0.0 will correctly make 1.0.0-rc.0 on branch release-1.0. However, after v1.0.0 is released, the next Release Candidate (if one is created with a PR) would be expected to be v1.0.1-rc.0 but would instead be v1.0.0-rc.1.

The PR that creates this RC would be trigger the v1.0.1 release, so the release candidate should also be for that version. However, it can only increment the RC number.

This is a limitation of the existing action-release action we are using.

@doebrowsk doebrowsk added the bug Something isn't working label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant