You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When handling uSyncService.ImportingItem setting e.Cancel=true actually allows processing the item and leaving on false skips the item. The exact reverse of what should happen based on the property name.
When the event is not hooked FireItemStartingEvent defaults to true. When the event is hooked and the handler is empty it defaults to false therefore skipping all items.
To Reproduce
Start from a vanilla umbraco+usync installation
hook the uSyncService.ImportingItem (see skeleton code below)
change something in usync folder and restart the app
Describe the bug
When handling
uSyncService.ImportingItem
settinge.Cancel=true
actually allows processing the item and leaving onfalse
skips the item. The exact reverse of what should happen based on the property name.When the event is not hooked
FireItemStartingEvent
defaults to true. When the event is hooked and the handler is empty it defaults to false therefore skipping all items.To Reproduce
uSyncService.ImportingItem
(see skeleton code below)This reproduces the bug:
This works around the bug:
Expected behavior
Setting e.Cancel to true should skip the item being imported.
About your Site (please complete the following information):
Additional context
I believe this line https://github.com/KevinJump/uSync8/blob/ca25f2eec51127b793d7b372380bcc6318b88141/uSync8.BackOffice/Services/uSyncService_Events.cs#L142 should be
Note that this would be a breaking change, no clue how to handle this without breaking the whole world.
The text was updated successfully, but these errors were encountered: