Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving handler settings when handler has keys puts them in the wrong place. #210

Closed
KevinJump opened this issue Mar 16, 2021 · 0 comments
Closed
Assignees
Labels
release/8.8.5 Patch Release

Comments

@KevinJump
Copy link
Owner

When you have custom handler settings in the config:

<Handler Alias="dataTypeHandler" Enabled="true" Actions="All">
  <Add Key="NoConfigEditors" Value="Umbraco.ColorPicker,Umbraco.Grid" />
</Handler>

saving via the backoffice adds an extra Settings key

<Handler Alias="dataTypeHandler" Enabled="true" Actions="All">
  <Add Key="NoConfigEditors" Value="Umbraco.ColorPicker" />
  <Settings>
    <Add Key="NoConfigEditors" Value="Umbraco.ColorPicker" />
  </Settings>
</Handler>

doesn't cause any issues but is annoying.

@KevinJump KevinJump self-assigned this Mar 16, 2021
@KevinJump KevinJump added the release/8.8.5 Patch Release label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/8.8.5 Patch Release
Projects
None yet
Development

No branches or pull requests

1 participant