Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events are not unregistered on termination #182

Closed
nzdev opened this issue Oct 26, 2020 · 2 comments
Closed

Events are not unregistered on termination #182

nzdev opened this issue Oct 26, 2020 · 2 comments
Assignees
@KevinJump
Labels
enhancement New feature or request release/8.8.0 major/minor release

Comments

@nzdev
Copy link

nzdev commented Oct 26, 2020

Describe the bug
Static uSync and umbraco events need to be unsubscribed on termination. See umbraco/Umbraco-CMS#8815

To Reproduce
Steps to reproduce the behavior:

  1. Terminate Umbraco

Expected behavior
Umbraco events unregistered on termination.

Screenshots
N/A

Desktop (please complete the following information):

  • Umbraco Version: 8.8
  • uSync Version: 8.7.1
  • OS: [e.g. iOS] Windows
  • Browser [e.g. chrome, safari] N/A

Additional context
umbraco/Umbraco-CMS#8815
@KevinJump
Copy link
Owner

thanks, good spot we will build that into the next release.

@KevinJump KevinJump added the enhancement New feature or request label Oct 26, 2020
@KevinJump KevinJump self-assigned this Oct 26, 2020
@KevinJump KevinJump added the release/8.8.0 major/minor release label Oct 26, 2020
@KevinJump
Copy link
Owner

will be part of release v8.8.0 (change info #f217f6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinJump KevinJump

Labels
enhancement New feature or request release/8.8.0 major/minor release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinJump @nzdev