smp: perform full AP initialization before releasing

All initialization routines and settings must be through, before letting BSP continue. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
KernelTestFramework · Nov 13, 2023 · 6bf4da9 · 6bf4da9
1 parent c481fb1
commit 6bf4da9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/smp/smp.c b/smp/smp.c
@@ -56,15 +56,16 @@ void __noreturn ap_startup(void) {
     init_traps(cpu);
     init_apic(ap_cpuid, apic_get_mode());
 
-    ap_callin = true;
-    smp_wmb();
-
     init_timers(cpu);
     sti();
 
     if (opt_fpu)
         enable_fpu();
 
+    /* Release BSP after full AP initialization */
+    ap_callin = true;
+    smp_wmb();
+
     while (true)
         run_tasks(cpu);
 
@@ -103,6 +104,7 @@ static __text_init void boot_cpu(cpu_t *cpu) {
 
     apic_wait_ready();
 
+    /* Wait for AP initialization */
     while (!ap_callin)
         cpu_relax();