Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally specify installer location for VS2015 Enterprise #3

Open
neutmute opened this issue Apr 21, 2016 · 4 comments
Open

Optionally specify installer location for VS2015 Enterprise #3

neutmute opened this issue Apr 21, 2016 · 4 comments

Comments

@neutmute
Copy link
Contributor

Just looking into updating to allow a local path to vs_enterprise.exe

I propose

  • the optional argument would be /installUrl=<path to vs_enterprise.exe>
  • the default url is overridden in vs-install.ps1 as opposed to ChocolateyInstall.ps1 which means it would potentially work for the other VS packages

Sound ok?

@KennethB
Copy link
Owner

KennethB commented Jun 7, 2016

Did you do any thing to implement this?

I'm finally getting some time to look at the chocolatey packages

@neutmute
Copy link
Contributor Author

neutmute commented Jun 8, 2016

err - yes i did actually. I started a brand new repository and was planning to use chocolatey triage process to take over the packages since you haven't been responding. Figured you were walking away from them.

Happy to do a big PR into this one if you want - I've made quite a few changes
I would need to update the nuspec links back to your repo first
https://github.com/neutmute/chocolatey-vs

@KennethB
Copy link
Owner

KennethB commented Jun 9, 2016

I'll build and do some testing on this today.
Saw your notes about the timeout and now I understand why some have been failing. I've got relatively fast connections at home and work so I'm able to pull the bits down before the timeout. I might ask ferventcoder if there is a way to set that in the package.

@neutmute
Copy link
Contributor Author

neutmute commented Jun 9, 2016

excellent - thanks!
re: timeout - I don't think you can control from the package - see here
http://superuser.com/questions/1016657/chocoletey-install-jdk8-never-ends

The user controls the timeout. The default timeout of 45 minutes is pretty big - however we found an issue where the download timeout was much less, and we've fixed it in the 0.9.10 beta to match the command timeout.

It seems from that download and install timeout are different but yeah - 7GB in 45mins can be a big ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants