Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variables #17

Open
batisteo opened this issue Apr 9, 2019 · 1 comment
Open

Environment variables #17

batisteo opened this issue Apr 9, 2019 · 1 comment

Comments

@batisteo
Copy link

batisteo commented Apr 9, 2019

It seems to me that the environment variable would be less cryptic this way:

site_url = env(SITE_URL)
site_url = env(SITE_URL or "localhost")
db_port = env(DB_PORT as integer or 5432)

What do you think?
@Keats
Copy link
Owner

Keats commented Apr 9, 2019

That's a good idea, it would free up the current syntax for interpolation like in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Keats @batisteo