Nd kavamint touchups #1422
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,25 @@ | ||
| syntax = "proto3"; | ||
| package kava.kavamint.v1beta1; | ||
|
|
||
| import "cosmos_proto/cosmos.proto"; | ||
| import "gogoproto/gogo.proto"; | ||
|
|
||
| option go_package = "github.com/kava-labs/kava/x/kavamint/types"; | ||
|
|
||
| // Params wraps the governance parameters for the kavamint module | ||
| message Params { | ||
| option (gogoproto.goproto_stringer) = false; | ||
|
There was a problem hiding this comment. We override the stringer since sdk.Dec doesn't work well with the built-in method |
||
| option (gogoproto.goproto_getters) = false; | ||
|
|
||
| // yearly inflation of total token supply minted to the community pool. | ||
| string community_pool_inflation = 1 [ | ||
|
There was a problem hiding this comment. sdk.Dec should be strings - cosmos/cosmos-sdk#10863 |
||
| (cosmos_proto.scalar) = "cosmos.Dec", | ||
| (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| // yearly inflation of bonded tokens minted for staking rewards to validators. | ||
| string staking_rewards_apy = 2 [ | ||
| (cosmos_proto.scalar) = "cosmos.Dec", | ||
| (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,30 +4,35 @@ import ( | |
| "fmt" | ||
|
|
||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" | ||
| "github.com/kava-labs/kava/x/kavamint/keeper" | ||
| "github.com/kava-labs/kava/x/kavamint/types" | ||
| ) | ||
|
|
||
| // InitGenesis new mint genesis | ||
| func InitGenesis(ctx sdk.Context, keeper keeper.Keeper, ak types.AccountKeeper, gs *types.GenesisState) { | ||
| // guard against invalid genesis | ||
| if err := gs.Validate(); err != nil { | ||
| panic(fmt.Sprintf("failed to validate %s genesis state: %s", types.ModuleName, err)) | ||
| } | ||
|
|
||
| // get module account -- creates one with allowed permissions if it does not exist | ||
| macc := ak.GetModuleAccount(ctx, types.ModuleName) | ||
|
There was a problem hiding this comment. This actually creates the module account, so the panic is just a double check incase that behavior changes There was a problem hiding this comment. yup, originally had no check but @DracoLi suggested i add one. is pulling the call out of the nil check just for clarity on the fact this code potentially does something rather than just checks if an account exists? There was a problem hiding this comment. I wrote it both ways, but thought this was cleaner and easier to read without the permission check nested. There was a problem hiding this comment. Could go either way on it, basically just increased the scope of |
||
| if macc == nil { | ||
| panic(fmt.Sprintf("%s module account has not been set", types.ModuleName)) | ||
| } | ||
|
|
||
| // check module account has minter permissions | ||
| if !macc.HasPermission(authtypes.Minter) { | ||
|
There was a problem hiding this comment. Good to check required permissions as well |
||
| panic(fmt.Sprintf("%s module account does not have %s permissions", types.ModuleName, authtypes.Minter)) | ||
| } | ||
|
|
||
| // set store state from genesis | ||
| keeper.SetParams(ctx, gs.Params) | ||
| keeper.SetPreviousBlockTime(ctx, gs.PreviousBlockTime) | ||
|
There was a problem hiding this comment. Change in behavior here -- we allow the zero value to be set, which then gets populated on the first block. Genesis assumes to previous block |
||
| } | ||
|
|
||
| // ExportGenesis returns a GenesisState for a given context and keeper. | ||
| func ExportGenesis(ctx sdk.Context, keeper keeper.Keeper) *types.GenesisState { | ||
| return types.NewGenesisState(keeper.GetParams(ctx), keeper.GetPreviousBlockTime(ctx)) | ||
|
There was a problem hiding this comment. No modifications to genesis on export. We test that an imported genesis always results in the same exported genesis -- best not to make modifications outside of abci |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required for the swagger to be generated