Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default thread count of 1 is confusing #224

Open
arthurp opened this issue May 11, 2021 · 0 comments
Open

Default thread count of 1 is confusing #224

arthurp opened this issue May 11, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arthurp
Copy link
Contributor

arthurp commented May 11, 2021 •
edited
Loading

Currently the Katana (libgalois) thread pool is by default 1 thread. This is weird. The default thread pool size should probably be the detected number of physical cores: katana::GetThreadPool().getMaxUsableThreads(). This will require a little lazy initialization, but shouldn't be too hard.

This issue is important as it could make Katana look bad since Katana is by default sequential.
@arthurp arthurp added enhancement New feature or request good first issue Good for newcomers labels May 11, 2021
@arthurp arthurp changed the title Default thread count is confusing Default thread count of 1 is confusing May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arthurp