Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why no kvg:element on non-hanzi graphics? #319

Closed
benkasminbullock opened this issue Apr 16, 2022 · 2 comments · Fixed by #356
Closed

Why no kvg:element on non-hanzi graphics? #319

benkasminbullock opened this issue Apr 16, 2022 · 2 comments · Fixed by #356
Labels
Documentation Errors and omissions in the KanjiVG documentation Duplicate A bug reported more than once Missing Things which should be there but aren't

Comments

@benkasminbullock
Copy link
Member

Why is there no kvg:element on the outermost group of the non-kanji graphics such as kanji/03093.svg?
@benkasminbullock benkasminbullock added Missing Things which should be there but aren't Documentation Errors and omissions in the KanjiVG documentation labels Apr 16, 2022
@benkasminbullock
Copy link
Member Author

If nobody has anything to say I'll go ahead and add the kvg:element field to the graphics.

@benkasminbullock benkasminbullock linked a pull request Apr 29, 2022 that will close this issue
Add kvg:element to the outermost group of non-kanji graphics #356
Merged
@benkasminbullock benkasminbullock added the Duplicate A bug reported more than once label May 3, 2022
@benkasminbullock
Copy link
Member Author

This was a duplicate of #170 which I'd closed earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Errors and omissions in the KanjiVG documentation Duplicate A bug reported more than once Missing Things which should be there but aren't
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add kvg:element to the outermost group of non-kanji graphics KanjiVG/kanjivg
1 participant
@benkasminbullock