Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stuff i want to add #6

Open
KTibow opened this issue Jan 1, 2023 · 21 comments
Open

stuff i want to add #6

KTibow opened this issue Jan 1, 2023 · 21 comments

Comments

@KTibow
Copy link
Owner

KTibow commented Jan 1, 2023

starting with aria-labels

@KTibow
Copy link
Owner Author

KTibow commented Jan 2, 2023

improve prop handling

@KTibow
Copy link
Owner Author

KTibow commented Jan 16, 2023

ripples

@KTibow
Copy link
Owner Author

KTibow commented Jan 16, 2023

@KTibow
Copy link
Owner Author

KTibow commented Jan 16, 2023

more components

@KTibow
Copy link
Owner Author

KTibow commented Jan 17, 2023

improve how colors are handled in theming

@KTibow
Copy link
Owner Author

KTibow commented Jan 27, 2023

better transitions
use inset
actually improve prop handling

@KTibow KTibow closed this as completed Jan 27, 2023
@JL102
Copy link
Contributor

JL102 commented Jan 27, 2023

Wanna add a roadmap and pin it to the list of issues? I'm interested in contributing but don't know which components you've got planned and/or which ones you're already working on. (pro tip if you didn't know, you can do checkboxes like this:

- [ ] foo bar
  • foo bar

and on github issues, clicking on the checkboxes will automatically edit the markdown to check/uncheck them!)

@KTibow KTibow reopened this Jan 27, 2023
@KTibow
Copy link
Owner Author

KTibow commented Jan 27, 2023

i'll make this an actual roadmap soon

@KTibow
Copy link
Owner Author

KTibow commented Jan 28, 2023

someday

  • density
  • ripples
  • aria research
  • more components

@KTibow KTibow pinned this issue Jan 28, 2023
@hubertmalkowski
Copy link
Contributor

hubertmalkowski commented Nov 23, 2023

Hey! I'm interested in adding new features to the library. Should I propose my ideas within this issue or create a new one specifically for each feature proposal?

@KTibow
Copy link
Owner Author

KTibow commented Nov 23, 2023

Make separate issues

@DeepBhat
Copy link

DeepBhat commented Mar 1, 2024

Do you have any plans for adding Time picker and DateTime picker?

@KTibow
Copy link
Owner Author

KTibow commented Mar 1, 2024

There aren't Docked variants documented in the spec. What's your use case? Should I try to make a Docked version anyway?

@DeepBhat
Copy link

DeepBhat commented Mar 2, 2024

This is the component I am talking about. I think it would be a great addition, and I'm willing to contribute.

@KTibow
Copy link
Owner Author

KTibow commented Mar 2, 2024

@DeepBhat That component is a modal. Modals work okay on mobile but it's better to just put a box with the picker next to the input. Not to mention that dragging the time selector would be hard to get right with JS.

My question is: why do you want this component? are you using it in a form?

@DeepBhat
Copy link

DeepBhat commented Mar 2, 2024

@KTibow That's correct, I'm using it in a form that allows the user to set a reminder on a ticket so they can get a notification. The reminder will have both date and time sections. I wasn't able to find any component for choose time in this library so that's why I asked.

@KTibow
Copy link
Owner Author

KTibow commented Mar 2, 2024

@DeepBhat

a. are the date and time sections going to be unified?
b. is the time optional?

@DeepBhat
Copy link

DeepBhat commented Mar 2, 2024

a. Yes, that's what I was tasked to do. Select a date, and then select the time. Datetime picker in android does the same thing
b. Selecting the time is mandatory.

@KTibow
Copy link
Owner Author

KTibow commented Mar 2, 2024

@DeepBhat

Since M3 doesn't have a dedicated mixed picker, how would you feel about using something like the one from GTasks?
(It has a button to open the picker. The picker has a date chooser, and a item that says set time. The item opens the time picker when clicked.)

@DeepBhat
Copy link

DeepBhat commented Mar 2, 2024

Yes thas a great idea. Honestly just having a time picker would suffice for my use case. I can work on creating one that follows material 3 guidelines. I just wanted to know if you have it in your road map.

@KTibow
Copy link
Owner Author

KTibow commented Mar 2, 2024

Yeah you can go ahead and try to make a time picker, I'll see how it turns out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants