Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing dependency in debian package #704

Merged
merged 3 commits into from
Sep 8, 2023
Merged

fix: add missing dependency in debian package #704

merged 3 commits into from
Sep 8, 2023

Conversation

Razuuu
Copy link
Contributor

@Razuuu Razuuu commented Sep 7, 2023

@KRTirtho
Copy link
Owner

KRTirtho commented Sep 8, 2023

It is kind of weird that it works fine on Ubuntu without libmpv2 or it's installed alongside mpv

@KRTirtho KRTirtho changed the base branch from master to dev September 8, 2023 03:52
@KRTirtho KRTirtho merged commit c987ea7 into KRTirtho:dev Sep 8, 2023
@Razuuu
Copy link
Contributor Author

Razuuu commented Sep 8, 2023

I can't explain lol

@acesabe
Copy link

acesabe commented Sep 18, 2023

On fully updated Ubuntu 22.04.3 LTS:

$ sudo dpkg -i ~/Downloads/Spotube-linux-x86_64.deb
(Reading database ... 298928 files and directories currently installed.)
Preparing to unpack .../Spotube-linux-x86_64.deb ...
Unpacking spotube (3.1.2+24) over (3.1.1+23) ...
dpkg: dependency problems prevent configuration of spotube:
spotube depends on libmpv2; however:
Package libmpv2 is not installed.

Of course there is no libmpv2 on Ubuntu 22.04.3 only libmpv1

Indeed installing without the deps seems to work anyway:

dpkg -i --ignore-depends=libmpv2 spotube.deb

I guess the issue can be resolved by adding | libmpv1 to the following line? >>

@KRTirtho
Copy link
Owner

@acesabe yes yes you're right

@KRTirtho
Copy link
Owner

@Razuuu can you add - libmpv2 | libmpv1 please?

@Razuuu
Copy link
Contributor Author

Razuuu commented Sep 19, 2023

I'm at work, i will do it this evening.

@KRTirtho
Copy link
Owner

Thanks 👍

@Razuuu
Copy link
Contributor Author

Razuuu commented Sep 19, 2023

Package can't be found via apt

joshua@b450:~$ apt search libmpv1
Sortierung… Fertig
Volltextsuche… Fertig
joshua@b450:~$ apt search libmpv2
Sortierung… Fertig
Volltextsuche… Fertig
libmpv2/testing,now 0.36.0-1 amd64  [installiert]
  Videoplayer auf Basis von MPlayer/mplayer2 (Client-Bibliothek)

I will do a commit that adds libmpv1 for ubuntu-based systems

@Razuuu
Copy link
Contributor Author

Razuuu commented Sep 19, 2023

@Razuuu can you add - libmpv2 | libmpv1 please?

https://github.com/Razuuu/spotube/commit/e5e42bcd49c4fadc9b78c2c6f9168f39a18d7064

i reordered to make the *1 package be the first one

meenbeese pushed a commit to meenbeese/spotube that referenced this pull request Sep 20, 2023
* chore: fill missing translations

* chore: vscode filenesting

* fix: add missing dependency in debian package

* fixes KRTirtho#703

---------

Co-authored-by: Kingkor Roy Tirtho <[email protected]>
meenbeese pushed a commit to meenbeese/spotube that referenced this pull request Sep 20, 2023
* chore: fill missing translations

* chore: vscode filenesting

* fix: add missing dependency in debian package

* fixes KRTirtho#703

---------

Co-authored-by: Kingkor Roy Tirtho <[email protected]>
meenbeese pushed a commit to meenbeese/spotube that referenced this pull request Sep 20, 2023
* chore: fill missing translations

* chore: vscode filenesting

* fix: add missing dependency in debian package

* fixes KRTirtho#703

---------

Co-authored-by: Kingkor Roy Tirtho <[email protected]>
@KRTirtho
Copy link
Owner

@Razuuu you've to create a new PR for new changes

@julien-garrigue julien-garrigue mentioned this pull request Dec 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency in debian package
3 participants