Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simplemde.min.js? #1

Closed
d9su opened this issue Oct 24, 2017 · 5 comments
Closed

Update simplemde.min.js? #1

d9su opened this issue Oct 24, 2017 · 5 comments

Comments

@d9su
Copy link
Contributor

d9su commented Oct 24, 2017

It seems the js file is very old and has some useless console logging. Updating it should solve the issue.

Also might wanna update the link in the readme to:
https://github.com/sparksuite/simplemde-markdown-editor

Thoughts?

@bhavyanshu
Copy link

@KHN190
I am facing the same issue. Please push updated version of simplemde.min.js. Thanks!

@KHN190
Copy link
Owner

KHN190 commented Oct 25, 2017

@bhavyanshu I have updated scripts to the latest simplende.min.js

Actually this gem is quite straight forward, you can just download the js from simplemde and replace them which is located in /vendor. Or if you are using Rails 5, put them in /app/assets and require them in application.js

@KHN190
Copy link
Owner

KHN190 commented Oct 25, 2017

Now require the gem in Gemfile:

gem 'simplemde-rails', git: 'https://github.com/KHN190/simplemde-rails'
# or
gem 'simplemde-rails', '~> 1.11.2'

@d9su
Copy link
Contributor Author

d9su commented Oct 25, 2017

Thanks for the quick update! I referenced this repo in railsadminteam/rails_admin#2949 for its convenience :P

@bhavyanshu
Copy link

@KHN190 I appreciate you getting back so quickly and fixing it. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants