cxx-qt-gen: allow for unused unsafe blocks and resolve no-exception issues #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we get build warnings as CXX has removed this attribute with changes in CXX 1.0.130
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11927 11962 +35
=========================================
+ Hits 11927 11962 +35 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ahayzen-kdab
force-pushed
the
fix-new-ci-failures-3
branch
from
fc55a25
to
bae305e
Compare
This allows for no exceptions to be generated for wasm.
ahayzen-kdab
force-pushed
the
fix-new-ci-failures-3
branch
7 times, most recently
from
deb5947
to
c2a71a0
Compare
This was referenced Nov 18, 2024
ahayzen-kdab
added
the
backport-candidate
ahayzen-kdab
commented
Nov 19, 2024
ahayzen-kdab
commented
Nov 19, 2024
ahayzen-kdab
commented
Nov 19, 2024
ahayzen-kdab
force-pushed
the
fix-new-ci-failures-3
branch
from
c2a71a0
to
2013a01
Compare
ahayzen-kdab
force-pushed
the
fix-new-ci-failures-3
branch
from
2013a01
to
ba8a355
Compare
ahayzen-kdab
force-pushed
the
fix-new-ci-failures-3
branch
from
ba8a355
to
e83c0ec
Compare
LeonMatthesKDAB
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.