-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MSRV info to crates #1110
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 71 71
Lines 12173 11927 -246
==========================================
- Hits 12173 11927 -246 ☔ View full report in Codecov by Sentry. |
MSRVs were found using https://github.com/foresterre/cargo-msrv, but when trying to run cargo test on the project-wide MSRV, it failed. I ran cargo test on 1.77.2 which is the highest MSRV for any of the crates, and it seemed that any rust version before 1.80.0 broke the generation tests. The diff showed that all the output simply didn't happen, so all tests passed except for the generation ones. This may be an issue with my locally installed toolchains however, but worth exploring. |
For me the generation tests work with 1.77.2, i suspect maybe you didn't have rustfmt installed with that toolchain enabled? As note that we call out to that. Or something similar ? |
f9fe38b
to
8cdd124
Compare
11fdf37
to
aae960f
Compare
3aa870b
to
d9a3700
Compare
3488552
to
6a95307
Compare
We appear to be hitting mozilla/sccache#2092 on macOS as we have reached the maximum cache size and it cannot remove old entries. Will need to debug if there is a way around this :-/ |
28448e0
to
ac6a00b
Compare
19f6a16
to
302639e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
302639e
to
98d5912
Compare
f808888
to
9832540
Compare
- Fix a clippy lint in lib.rs - Pin rust version in all CI jobs that use cargo commands
9832540
to
7a56f8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
Adding an MSRV to crates, in order to enforce an optional clippy lint which prevents newer features breaking things.