Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ward routes are registered #24

Open
tpetry opened this issue Oct 4, 2020 · 4 comments
Open

Ward routes are registered #24

tpetry opened this issue Oct 4, 2020 · 4 comments

Comments

@tpetry
Copy link
Contributor

tpetry commented Oct 4, 2020

You have clearly stated that KABBOUCHI/nova-logs-tool is built on KABBOUCHI/laravel-ward which is absolutely ok. But using the nova plugin should not publish routes to ward:

Domain Method URI Name Action Middleware
GET|HEAD ward/api/daily-log-files KABBOUCHI\Ward\Http\Controllers\Api\LogsController@dailyLogFiles web,KABBOUCHI\Ward\Http\Middleware\Authenticate
DELETE ward/api/logs KABBOUCHI\Ward\Http\Controllers\Api\LogsController@delete web,KABBOUCHI\Ward\Http\Middleware\Authenticate
GET|HEAD ward/api/logs KABBOUCHI\Ward\Http\Controllers\Api\LogsController@index web,KABBOUCHI\Ward\Http\Middleware\Authenticate
GET|HEAD ward/api/logs/{log} KABBOUCHI\Ward\Http\Controllers\Api\LogsController@show web,KABBOUCHI\Ward\Http\Middleware\Authenticate
GET|HEAD ward/{view?} ward.index KABBOUCHI\Ward\Http\Controllers\WardController@index web,KABBOUCHI\Ward\Http\Middleware\Authenticate
@KABBOUCHI
Copy link
Owner

plz add this LOG_VIEWER_ENABLE_ROUTES=false to .env file

@tpetry
Copy link
Contributor Author

tpetry commented Oct 8, 2020

This removes the routes but not everyone is aware of this setting. The routes should not have been registered in the first place, my application failed an audit because of some unknown unexplainable routes registered.

@KABBOUCHI
Copy link
Owner

I'll add it to readme file

@stepanenko3
Copy link

@tpetry

https://github.com/stepanenko3/nova-logs-tool/releases/tag/v1.1.1

This release remove ward routes
I'll do a PR a little later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants