Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion of Bool and Zero/One leads to stackoverflow. #20

Closed
lkdvos opened this issue Nov 5, 2024 · 0 comments · Fixed by #21
Closed

Promotion of Bool and Zero/One leads to stackoverflow. #20

lkdvos opened this issue Nov 5, 2024 · 0 comments · Fixed by #21

Comments

@lkdvos
Copy link
Collaborator

lkdvos commented Nov 5, 2024

MWE

using VectorInterface: One, Zero
promote(true, One()) # stackoverflow
promote(true, Zero()) # stackoverflow

This is because both Bool and One/Zero define promotion rules that return the other number type:

promote_rule(Bool, One) # One
promote_rule(One, Bool) # Bool

I'll fix this in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant