Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ASF console window flash on input request and stop flashing once provided #2998

Closed
7 tasks done
JustArchi opened this issue Sep 6, 2023 · 0 comments · Fixed by #3158
Closed
7 tasks done

Make ASF console window flash on input request and stop flashing once provided #2998

JustArchi opened this issue Sep 6, 2023 · 0 comments · Fixed by #3158
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! ⚪ No priority Issues marked with this label are not being actively worked on for time being. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@JustArchi
Copy link
Member

Checklist

Enhancement purpose

OnInputStart() and OnInputEnd() in Logging.cs should call OS.FlashWindow() and OS.StopFlashingWindow() or something like that, which will signalize requirement of input.

Solution

https://stackoverflow.com/questions/2923250/is-there-a-way-to-make-a-console-window-flash-in-the-task-bar-programmatically

Why currently available solutions are not sufficient?

Console beeping is better than nothing, but we can utilize this windows-only function for better integration.

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

If somebody likes to hack, feel free to send PR before I have time to get down to this.

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! and removed 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Sep 6, 2023
@JustArchi JustArchi added ⚪ No priority Issues marked with this label are not being actively worked on for time being. and removed 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. labels Nov 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
@JustArchi JustArchi added the 🏁 Finished Issues marked with this label were finished already and no further work is required on them. label Jun 17, 2024
@JustArchi JustArchi removed the 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. label Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! ⚪ No priority Issues marked with this label are not being actively worked on for time being. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant