Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASF not working with certain passwords #2903

Closed
JustArchi opened this issue May 18, 2023 Discussed in #2899 · 6 comments
Closed

ASF not working with certain passwords #2903

JustArchi opened this issue May 18, 2023 Discussed in #2899 · 6 comments
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list.

Comments

@JustArchi
Copy link
Member

Discussed in #2899

Originally posted by AdamT20054 May 16, 2023
Are there limits to what password ASF can accept?

I remember a while ago I had issues with ASF using long complex passwords, so I had to switch to a much shorter and weaker one.
I've come back to ASF with a stronger password and again I get the InvalidPassword error, are there any limitations to what the program allows for the steam password (eg, length, characters, special characters)?

(Absolutely certain there is nothing wrong with the credentials, not rate limited, etc)

@JustArchi JustArchi added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. labels May 18, 2023
@JustArchi
Copy link
Member Author

Reproduced with password:

Lw{R7{FdA33h+h*~M9nXmQ}`9P5pd-t*Yc:tm-C`No-{\Qj2Z[:}{[Q(KxL[PzjA9r9]*m~K)'Yy>'}Jk;f+cu4cmH&[?L2i+}fUqqrqkQ=w~3$t4J?"=3+7Rav##FT~

@JustArchi
Copy link
Member Author

JustArchi commented May 18, 2023

My blind guess is that Steam artificially limits passwords sent over to only certain characters (length limit), since in similar way they cut non-ASCII characters out of it, pending check using NH2 how the official Steam client signs in.

@JustArchi
Copy link
Member Author

                s = t.replace(/[^\x00-\x7F]/g, '').slice(0, 64);

Bingo.

@nolddor
Copy link
Contributor

nolddor commented May 18, 2023

Good catch mate!

@JustArchi
Copy link
Member Author

JustArchi commented May 18, 2023

@AdamT20054 Steam artificially cuts passwords to first 64 characters. Your 128-char password is effectively first 64 characters exclusively, and you can use first 64 characters to log in, whether in official client, web browser or ASF - also versions without fix above.

I've added logic for ASF to automatically cut those 64 characters in case somebody uses longer passwords, but from security standpoint, the passwords are 64 characters at most. I can't believe Valve didn't even care to tell people that longer passwords are not accepted, but then again what did I expect if they didn't even tell people non-ASCII characters are trimmed as well.

Sigh, fixed.

@AdamT20054
Copy link

Cheers!
Valve just doing valve things i guess :p

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list.
Projects
None yet
Development

No branches or pull requests

3 participants