Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jobState.hasKey documentation to cover edge case #696

Open
austinkelleher opened this issue Apr 21, 2022 · 0 comments
Open

Update jobState.hasKey documentation to cover edge case #696

austinkelleher opened this issue Apr 21, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@austinkelleher
Copy link
Contributor

The Qualys integration was using awaiting the result of jobState.hasKey and firing off multiple promises with pQueue. The Qualys integration was occasionally seeing DUPLICATE_KEY_DETECTED errors being thrown despite checking whether the graph object _key exists before adding the new entity to the jobState. Tests were added as part of the investigation into the issue. See: #694

The Qualys integration fix can be found here: JupiterOne-Archives/graph-qualys#190

The documentation and JSDoc code comments for jobState.hasKey should be updated to call out the caveats.
@austinkelleher austinkelleher added documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 21, 2022
@austinkelleher austinkelleher mentioned this issue Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@austinkelleher