Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Fix custom profile step and release v1.3.2 #26

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix custom profile step and release v1.3.2 #26

merged 1 commit into from
Jun 27, 2024

Conversation

jzolo22
Copy link
Contributor

@jzolo22 jzolo22 commented Jun 27, 2024

Description

Thank you for contributing to a JupiterOne integration!

Should fix this error:
image

Summary

Type of change

Please leave any irrelevant options unchecked.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist

General Development Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Integration Development Checklist:

Please leave any irrelevant options unchecked.

  • I have checked for additional permissions required to call any new API
    endpoints, and have documented any additional permissions in
    jupiterone.md, where necessary.
  • My changes properly paginate the target service provider's API
  • My changes properly handle rate limiting of the target service provider's
    API
  • My new integration step is instrumented to execute in the correct order
    using dependsOn
  • I have referred to the
    JupiterOne data model
    to ensure that any new entities/relationships, and relevant properties,
    match the recommended model for this class of data
  • I have updated the CHANGELOG.md file to describe my changes
  • When changes include modifications to existing graph data ingestion, I've
    reviewed all existing managed questions referencing the entities,
    relationships, and their property names, to ensure those questions still
    function with my changes.

@jzolo22 jzolo22 requested a review from a team as a code owner June 27, 2024 14:15
@jzolo22 jzolo22 merged commit f8e7860 into main Jun 27, 2024
9 checks passed
@jzolo22 jzolo22 deleted the release-1.3.2 branch June 27, 2024 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants