From 438683863883afaa414630c5cd5e9a5da0a14981 Mon Sep 17 00:00:00 2001
From: Mohammed Aldakhil <41828058+Marco-9456@users.noreply.github.com>
Date: Thu, 25 Apr 2024 00:04:05 +0200
Subject: [PATCH] Update android.yml

# Updates!
- Updated the `upload-artifact` action to v4, since v3 is now deprecated.
- Updated the `setup-java` to v4 and pumped java-version to `21`.
- The uploaded artifacts will be now deleted after 20 days.
---
 .github/workflows/android.yml | 64 +++++++++++++++++++----------------
 1 file changed, 34 insertions(+), 30 deletions(-)

diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
index edde3b3d2..24135af66 100644
--- a/.github/workflows/android.yml
+++ b/.github/workflows/android.yml
@@ -4,37 +4,41 @@ on:
   workflow_dispatch:
 
 jobs:
-  build:
 
+  build:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
-
-      - name: set up JDK 17
-        uses: actions/setup-java@v3
-        with:
-          java-version: '17'
-          distribution: 'temurin'
-          cache: gradle
-
-      - name: Setup Android SDK
-        uses: android-actions/setup-android@v3
-
-      - uses: gradle/actions/setup-gradle@v3
-      - run: gradle assembleRelease
-
-      - uses: ilharp/sign-android-release@v1
-        name: Sign app APK
-        id: sign_app
-        with:
-          releaseDir: app/build/outputs/apk/release
-          signingKey: ${{ secrets.SIGNING_KEY }}
-          keyAlias: ${{ secrets.ALIAS }}
-          keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }}
-          keyPassword: ${{ secrets.KEY_PASSWORD }}
-
-      - uses: actions/upload-artifact@v3
-        with:
-          name: Signed apks
-          path: app/build/outputs/apk/release/*-arm64-v8a-release-signed.apk
\ No newline at end of file
+    - uses: actions/checkout@v4
+
+    - name: set up JDK 21
+      uses: actions/setup-java@v4
+      with:
+        java-version: '21'
+        distribution: 'temurin'
+        cache: 'gradle'
+
+    - name: Setup Android SDK
+      uses: android-actions/setup-android@v3
+
+    - uses: gradle/actions/setup-gradle@v3
+
+    - run: gradle assembleRelease
+
+    - name: Sign app APK
+      id: sign_app
+      uses: ilharp/sign-android-release@nightly
+      with:
+        releaseDir: app/build/outputs/apk/release
+        signingKey: ${{ secrets.SIGNING_KEY }}
+        keyAlias: ${{ secrets.ALIAS }}
+        keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }}
+        keyPassword: ${{ secrets.KEY_PASSWORD }}
+
+    - name: Upload Artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: signed-apks
+        path: app/build/outputs/apk/release/*-arm64-v8a-release-signed.apk
+        if-no-files-found: error
+        retention-days: 20