Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing yt-dlp plugins #1793

Open
2 of 6 tasks
shifoc opened this issue Oct 10, 2024 · 9 comments
Open
2 of 6 tasks

Allow installing yt-dlp plugins #1793

shifoc opened this issue Oct 10, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@shifoc
Copy link

shifoc commented Oct 10, 2024

Checklist

  • This feature I'm requesting is already implemented in yt-dlp.
  • This feature is merely a UI/UX update.
  • This feature is suitable for primary users with little knowledge about yt-dlp.
  • This feature is available for most websites, not only the video platform I use.
  • This feature is suitable for a large variety of videos.
  • This feature is not going to conflict with many of the existing options.

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

No response

Video link

No response

Additional context

No response

@shifoc shifoc added enhancement New feature or request new issue This issue is not triaged labels Oct 10, 2024
@VishweshBhavsar23
Copy link

App version: 1.13.0 (11300)
Device information: Android 13 (API 33)
Supported ABIs: [arm64-v8a, armeabi-v7a, armeabi]
Yt-dlp version:

URL: https://www.instagram.com/reel/DBKnJy4u2mw/?igsh=dWhpaTQwZ28xODhj
WARNING: [Instagram] DBKnJy4u2mw: General metadata extraction failed (some metadata might be missing).
WARNING: [Instagram] unable to extract shared data; please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U
WARNING: [Instagram] Main webpage is locked behind the login page. Retrying with embed webpage (some metadata might be missing).
WARNING: [Instagram] unable to extract additional data; please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U
ERROR: [Instagram] DBKnJy4u2mw: Requested content is not available, rate-limit reached or login required. Use --cookies, --cookies-from-browser, --username and --password, --netrc-cmd, or --netrc (instagram) to provide account credentials

@imranh2
Copy link

imranh2 commented Oct 20, 2024

I also wanted to do this so I added this functionality to yt-dlp so we can use the new option --plugin-dirs to do this once the nightly build releases

yt-dlp/yt-dlp#11277

@JunkFood02
Copy link
Owner

@imranh2 Cool! Could you tell me what plugin do you want to use?

@JunkFood02 JunkFood02 removed the new issue This issue is not triaged label Oct 21, 2024
@imranh2
Copy link

imranh2 commented Oct 22, 2024

FYI make sure seal has the All files access/MANAGE_EXTERNAL_STORAGE permission so it can actually read the plugin files and it just works as part of a custom command.

@shifoc
Copy link
Author

shifoc commented Oct 22, 2024

@imranh2 Cool! Could you tell me what plugin do you want to use?

personally there are multiple plugins, this is one example: https://github.com/pratikpatel8982/yt-dlp-hianime

@shifoc
Copy link
Author

shifoc commented Oct 22, 2024

I also wanted to do this so I added this functionality to yt-dlp so we can use the new option --plugin-dirs to do this once the nightly build releases

yt-dlp/yt-dlp#11277

https://github.com/yt-dlp/yt-dlp/releases/tag/2024.10.22 it seems they released it. did you try it yet?

@JunkFood02
Copy link
Owner

FYI make sure seal has the All files access/MANAGE_EXTERNAL_STORAGE permission so it can actually read the plugin files and it just works as part of a custom command.

Actually we're planning to remove this permission by the release of v2.0. So we'll need an in-app approach (with some UI) to handle installation/uninstallation of plugins

@JunkFood02
Copy link
Owner

it seems they released it. did you try it yet?

You can download the source of a plugin, unzip it to a directory and use the new --plugin-dirs in custom commands to use it. (you'll need All files access speciall permission for now)

@imranh2
Copy link

imranh2 commented Oct 22, 2024

Actually we're planning to remove this permission by the release of v2.0. So we'll need an in-app approach (with some UI) to handle installation/uninstallation of plugins

A UI approach would be great, until then I just humbly ask you keep the permission around so people can get this to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants