Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher Progress display #138

Closed
tompipe opened this issue Oct 14, 2021 · 2 comments
Closed

Publisher Progress display #138

tompipe opened this issue Oct 14, 2021 · 2 comments
Labels
bug Something isn't working release/8.11.3 patch release

Comments

@tompipe
Copy link

tompipe commented Oct 14, 2021

Describe the bug
When using publisher to transfer content, we've noticed that we weren't getting the awesome animated progress display.

image

Eventually, the list of changes for the items would pop up, but no progress would be shown.

I finally had time to look at it, and found the following in the browser console

image

I had a look at App_Plugins\uSyncPublisher\components\uSyncPublishingActionComponent.js and made the following change to line 234

function hasView(action) {
   return action.view != null && action.view.length > 0;
}

i.e removed an equals from the null check, it seems that view is undefined when the call to uSyncPublisherApi/GetAction returns the action with the alias=pullFetch

Version (please complete the following information):

  • Umbraco Version: 8.17.0
  • uSync Version 8.10.3
  • uSync.Complete Version 8.11.3

(but also experienced on prior versions) - I think it possibly began in May when we upgraded from 8.9.0 to 8.9.1

@KevinJump
Copy link
Member

oddly i can't reproduce it, but i can see how it might happen, will add a better check to that file for the next release.

@KevinJump KevinJump added bug Something isn't working release/8.11.3 patch release labels Oct 14, 2021
@KevinJump
Copy link
Member

fixed in 8.11.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release/8.11.3 patch release
Projects
None yet
Development

No branches or pull requests

2 participants