Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciinema player not respecting autoPlay #94

Open
tomups opened this issue May 1, 2024 · 0 comments · May be fixed by #95
Open

Asciinema player not respecting autoPlay #94

tomups opened this issue May 1, 2024 · 0 comments · May be fixed by #95

Comments

@tomups
Copy link

tomups commented May 1, 2024

I see you are using an intersection observer to auto play and pause the asciinema player:

const observer = new IntersectionObserver((entries) => {
entries.forEach((entry) => {
const player = players.get(entry.target);
if (player) {
if (entry.isIntersecting) {
player.play();
} else {
player.pause();
}
}
});
}, options);

It's a nice to have, but unfortunately as it's not configurable, it's like if the autoPlay setting of asciinema is always true.

It would be great if this play-on-view setting was configurable as well and not enabled by default, as in my case I prefer users to start the recording manually.

@tomups tomups linked a pull request May 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant