Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification for ddim_sample_loop_known #67

Open
bennymi opened this issue May 5, 2024 · 0 comments
Open

Clarification for ddim_sample_loop_known #67

bennymi opened this issue May 5, 2024 · 0 comments

Comments

@bennymi
Copy link

bennymi commented May 5, 2024

Hi, thank you for providing the code. I have a question about the ddim_sample_loop_known function. Why do we set the timesteps in this line (

t = th.randint(499,500, (b,), device=device).long().to(device)
) to be 499?

Shouldn't the SpacedDiffusion model and the timestep_respacing with something like ddim 50 automatically take care of the correct beta scheduling to reduce the number of timesteps?

In the original ddim_sample_loop implementation, there is no such thing: https://github.com/openai/improved-diffusion/blob/1bc7bbbdc414d83d4abf2ad8cc1446dc36c4e4d5/improved_diffusion/gaussian_diffusion.py#L562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant