Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to the artifact path in a relocatable way #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Allow access to the artifact path in a relocatable way #32

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f582dd5
add artifact_dir()
lcontento Oct 29, 2024
2c2cbab
Add deprecation
lcontento Nov 4, 2024
b62184d
improve @deprecate_binding
lcontento Nov 4, 2024
fb2f095
add comments + precompile statement
lcontento Nov 4, 2024
924cf92
Update src/TZJData.jl
lcontento Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/TZJData.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ module TZJData

using Artifacts

const ARTIFACT_DIR = artifact"tzjdata"
artifact_dir() = artifact"tzjdata"
lcontento marked this conversation as resolved.
Show resolved Hide resolved
Base.@deprecate_binding ARTIFACT_DIR artifact_dir() false
# Why not simply use `const ARTIFACT_DIR = artifact"tzjdata"`?
# The problem is that `ARTIFACT_DIR` would be set to the artifact path at the time of precompilation.
# If the Julia depot is afterwards relocated,
# ARTIFACT_DIR will continue to point to the old no-longer-valid location.
lcontento marked this conversation as resolved.
Show resolved Hide resolved
# This occurs for example if TimeZones.jl is included inside a system image.

lcontento marked this conversation as resolved.
Show resolved Hide resolved
const TZDATA_VERSION = let
artifact_dict = Artifacts.parse_toml(joinpath(@__DIR__, "..", "Artifacts.toml"))
Expand All @@ -11,4 +17,10 @@ const TZDATA_VERSION = let
m !== nothing ? m[:version] : error("Unable to determine tzdata version")
end

precompile(artifact_dir, ())
# `@deprecate_binding ARTIFACT_DIR artifact_dir()`
# will have already precompiled `artifact_dir()`
# but once the deprecated binding is removed
# an explicit precompile statement will be necessary.

end
Loading