Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #86

Merged
merged 4 commits into from
Nov 22, 2021
Merged

update deps #86

merged 4 commits into from
Nov 22, 2021

Conversation

jd-lara
Copy link
Contributor

@jd-lara jd-lara commented Nov 19, 2021

Updates MOI, MA and JuMP depedencies.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #86 (d16eb68) into master (a564648) will increase coverage by 2.31%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   71.19%   73.51%   +2.31%     
==========================================
  Files           8        8              
  Lines         486      521      +35     
==========================================
+ Hits          346      383      +37     
+ Misses        140      138       -2     
Impacted Files Coverage Δ
src/mutable_arithmetics.jl 67.92% <40.00%> (+3.92%) ⬆️
src/ParameterJuMP.jl 91.66% <0.00%> (+0.96%) ⬆️
src/print.jl 78.26% <0.00%> (+0.98%) ⬆️
src/variable_interface.jl 48.00% <0.00%> (+2.16%) ⬆️
src/constraints.jl 76.16% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a564648...d16eb68. Read the comment docs.

@jd-lara
Copy link
Contributor Author

jd-lara commented Nov 20, 2021

@odow this seems ready for review

@odow
Copy link
Member

odow commented Nov 21, 2021

So just the MA change?

@jd-lara
Copy link
Contributor Author

jd-lara commented Nov 21, 2021

So far yeah, all of our tests are passing so I don't have anything else that might require changes

@jd-lara
Copy link
Contributor Author

jd-lara commented Nov 22, 2021

@odow I ran all the testing we can do over the weekend. This should be merged and tagged as soon as you can please.

@odow odow merged commit 3a3ad6f into JuliaStochOpt:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants