Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessors for gridpoints and corresponding densities #67

Closed
tpapp opened this issue Feb 8, 2019 · 7 comments · Fixed by #72
Closed

accessors for gridpoints and corresponding densities #67

tpapp opened this issue Feb 8, 2019 · 7 comments · Fixed by #72

Comments

@tpapp
Copy link
Collaborator

tpapp commented Feb 8, 2019

It is unclear if eg for univariate densities the slots x and density can be used (ie are part of the API and can be expected to be stable, not an internal implementation detail).

It would be great to document this, or alternatively provide accessor functions. Similarly for bivariate.

If the package maintainers clarify their intention, I would be happy to make a PR.

@tpapp
Copy link
Collaborator Author

tpapp commented Feb 8, 2019

Could also help with #66.

@tpapp
Copy link
Collaborator Author

tpapp commented Feb 11, 2019

Bump --- can anyone clarify this?

@tpapp
Copy link
Collaborator Author

tpapp commented Feb 15, 2019

@simonbyrne , can you help me with this? Again, I just need a decision on what would be preferred, happy to make the PR.

@tlnagy
Copy link
Contributor

tlnagy commented Aug 9, 2019

This package would benefit greatly from these accessors and a tutorial. I would prefer to have documented functions for access to prevent breakage if internals get moved around.

@simonbyrne
Copy link
Member

I'm afraid I don't have the bandwidth to contribute to this repository for the forseeable future. @tpapp and @tlnagy I've added you as collaborators, please do as you see fit.

@tpapp
Copy link
Collaborator Author

tpapp commented Sep 12, 2019

@simonbyrne, are you sure you added me as a collaborator? I don't seem to have access rights. In any case, I will just fork in the meantime.

@simonbyrne
Copy link
Member

@tpapp tpapp closed this as completed in #72 Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants