Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml to include Apple Silicon #24

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Update ci.yml to include Apple Silicon #24

merged 2 commits into from
Feb 22, 2024

Conversation

ViralBShah
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41327dd) 55.85% compared to head (31ff21c) 55.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   55.85%   55.85%           
=======================================
  Files           2        2           
  Lines         564      564           
=======================================
  Hits          315      315           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rayegun
Copy link
Member

rayegun commented Feb 22, 2024

Huh, I didn't think KLU was broken on 1.6. I'll try to fix this, although if we're bumping LTS soon it might not be worth

@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 22, 2024

Weirdly enough only on 64-bit!

The wrappers we generate are specific to the version of SuiteSparse that ships with Julia (and there were several changes recently around the SuiteSparse internals). So I wouldn't expect it to work at all. I thought it will just pick an older version or find a version issue - but surprised that it works on 32-bit and crashes on 64-bit.

Pkg does refuse to install it on 1.6 (you get KLU 0.4.1, which works fine). So I think we can just remove the 1.6 tests here.

@ViralBShah ViralBShah merged commit d9fcc3d into main Feb 22, 2024
9 checks passed
@ViralBShah ViralBShah deleted the vs/ci-m1 branch February 22, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants