Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to divide the package into different packages? #40

Closed
htyeim opened this issue Apr 26, 2020 · 5 comments
Closed

Is it possible to divide the package into different packages? #40

htyeim opened this issue Apr 26, 2020 · 5 comments

Comments

@htyeim
Copy link

htyeim commented Apr 26, 2020

It is a nice package! I have learned both Julia and simulation by reading the code.
I wonder if it is possible to divide the whole package into different packages. Because I think some parts of the code are also useful in other fields (e.g., GNSS navigation, ionosphere). I think each model (IGRF, MSISE00, etc) can be divided into an individual package. I read some parts of the code and found that these models are almost independent. if this huge package consists of many smaller packages which are separated from the package by using , it would be easier to read, maintain, and use.

@ronisbr
Copy link
Member

ronisbr commented Apr 26, 2020

Hi @htyeim !

It is a nice package! I have learned both Julia and simulation by reading the code.

I am glad this package is being useful!

I wonder if it is possible to divide the whole package into different packages. Because I think some parts of the code are also useful in other fields (e.g., GNSS navigation, ionosphere). I think each model (IGRF, MSISE00, etc) can be divided into an individual package. I read some parts of the code and found that these models are almost independent.

Yes, this is the goal. We already have an opened issue #1 about this. The proposal is start spliting the packages internally. Right now, we have two submodules: SPG4 and TLE. When all the submodules are created, then we can start to register new packages.

if this huge package consists of many smaller packages which are separated from the package by using , it would be easier to read, maintain, and use.

Actually, it is quite the opposite. I had this discussion with Julia devs when this package was created. It is way much harder to maintain a lot of small packages than it is to maintain a single big one. The updates take time, the registration process takes time, we always have to be sure that the required versions match (e.g., you modify a package with a breaking changing for another one), etc.

Hence, I decided that I will focus on adding the many missing features here. When it makes sense, I will split into submodules. However, I think the right move is to split the packages only (and if) we have enough maintainers to help me.

@helgee
Copy link
Member

helgee commented Apr 26, 2020

I agree. I split my Astrodynamics.jl way too early and have been dealing with the repercussions for years.

Nevertheless, it should happen at some point when everything is nicely sorted into submodules and there is actual demand from other fields who want nothing to do with satellites 😄

@ronisbr
Copy link
Member

ronisbr commented Apr 26, 2020

Nevertheless, it should happen at some point when everything is nicely sorted into submodules and there is actual demand from other fields who want nothing to do with satellites 😄

I totally agree! For example, I had some demands related to the atmospheric models (which are used in ionosphere research). Hence, we can start with it. But, I think it is better to focus our very small workforce in implementing new features at this moment.

@htyeim
Copy link
Author

htyeim commented Apr 27, 2020

Thank you for your reply! I completely understand your priority at the moment.

I mostly use C++ and Python before, but after some comparing, I have rewritten some of my code in Julia. But, so far, I am not very familiar with Julia, so I only start to rewrite my code when necessary. For example, only when Cxx.jl package broken in v1.4, I started rewriting the part of GPSTk C++ code I used before in Julia.
My research now is related to ionospheric disturbances using GNSS-TEC data. I think space_indices, atmospheric models, and IGRF model are very useful for me. I will try to organize some of these code for my own use and make the repositories public later. But as I said before I am not very familiar with Julia, so these might only be considered some tests.

I have heard that NRLMSISE model may be updated this year (after 20 years...), so maybe this can be one of the new features of this great package later :)

@ronisbr
Copy link
Member

ronisbr commented Jul 11, 2021

I will close this as dup of #1.

@ronisbr ronisbr closed this as completed Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants