-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should layout be column major? #2047
Comments
IMO, this should be fixed in |
It's a big breaking change |
Probably, but this is why major releases are for. |
Yeah ... if it is clearly explained on the Readme / Changelog what needs to be changed in user code it should be fine! |
Note for the implementation: this behavior should probably depend on a global flag set by default to column major, but with the ability to be toggled to row major if needed. Arguments in favor:
Arguments against:
|
The
layout
option inPlots
is row-major. I mean thatplot(rand(100,4), layout = (2,2))
places series 1 and 2 on the first row instead of on the first column.Whereas (for example)
reshape(1:4, 2,2)
gives 1 and 2 on the first column.Since Julia arrays are generally column major, it might be worth making
layouts
column major as well for consistency.The text was updated successfully, but these errors were encountered: