Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name clash #2

Closed
BeastyBlacksmith opened this issue Sep 1, 2022 · 9 comments
Closed

Name clash #2

BeastyBlacksmith opened this issue Sep 1, 2022 · 9 comments

Comments

@BeastyBlacksmith
Copy link
Member

We clash names with https://github.com/tkf/Kaleido.jl
Other good name suggestions? @joshday, @sglyon

@BeastyBlacksmith
Copy link
Member Author

PlotlySave.jl exists already, Savefig.jl would still be available, but is maybe a bit too broad.
PlotlyFile.jl or Plotly2File.jl would also be available.

@sglyon
Copy link
Member

sglyon commented Sep 1, 2022

Maybe we coordinate with @hhaensel to use PlotlySave.jl?

@joshday
Copy link
Collaborator

joshday commented Sep 1, 2022

PlotlyKaleido?

It looks like PlotlySave implements FileIO.save, which we would be unable to do since the types we need live in different packages.

@hhaensel
Copy link

hhaensel commented Sep 1, 2022

Hi,
Not sure what the scope of that packages shall be. If it is identical to mine, feel free to take over PlotlySave.
I offered this already some time ago before I registered the Package.
In that case I propose that PlotlySave is migrated to JuliaPlots

@BeastyBlacksmith
Copy link
Member Author

The scope of this package is much narrower than that of the current PlotlySave, it takes a valid plotlyplot json string and creates an output file from it, if you don't intend to develop/maintain it we could move it to JuliaPlots, make a breaking realease and replace it with this version of the package since according to juliahub PlotlySave has 0 Dependents.

Otherwise PlotlyKaleido would also work for me.

@joshday
Copy link
Collaborator

joshday commented Sep 2, 2022

My vote would be to register this repo as PlotlyKaleido as the path of least resistance.

@hhaensel
Copy link

hhaensel commented Sep 4, 2022

If you are interested you can migrate the Package to JuliaPlots and publish a new version.
Wouldn't you think that it's interesting to keep the savefig command as is?

I understand that the definition of FileIO.save() is strictly speaking type piracy, although I still find the syntax tempting. Not sure, how a correct way out could look like. Perhaps by defining a format type that resides within PlotlySave and which is mandatory when calling FileIO.save ...?
Let me know what you think.

@BeastyBlacksmith
Copy link
Member Author

I've gone with PlotlyKaleido now, since I do find it awkward to change the scope of a package between major-versions.

@BeastyBlacksmith
Copy link
Member Author

JuliaRegistries/General#67704 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants