We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Blink 0.6.0 electron was upgraded from 0.35.2 to 1.7.10
This somehow broke things for PlotlyJS.jl
I need to open an issue (or better yet a PR) against Blink.jl, but I haven't yet isolated the issue.
cc @pfitzseb
The text was updated successfully, but these errors were encountered:
The problem here seems to be that Window() isn't blocking and doesn't provide a callback, right?
Window()
Sorry, something went wrong.
Yep, I think that’s right!
I’m not sure why this only surfaced with the upgrade of electron though... did that become async on the electron side?
You were probably only getting lucky, I think. At least the Blink tests always had a sleep statement in them (which you added 😄).
sleep
The right way forward is to make the complete Blink API blocking or take callbacks (with the latter being the much preferable option), imho.
That would be great, though I don’t see why it has to be an either or.
If we use callbacks then that can form the basis of the async api and we can use the callbacks to also provide a sync api
async
sync
No branches or pull requests
In Blink 0.6.0 electron was upgraded from 0.35.2 to 1.7.10
This somehow broke things for PlotlyJS.jl
I need to open an issue (or better yet a PR) against Blink.jl, but I haven't yet isolated the issue.
cc @pfitzseb
The text was updated successfully, but these errors were encountered: