From 0cfcb4c348e2ca30ea8f43d83ab0cfdb9c91ebe6 Mon Sep 17 00:00:00 2001
From: Spencer Lyon <spencerlyon2@gmail.com>
Date: Thu, 1 Feb 2018 11:38:39 -0500
Subject: [PATCH] TEST: add tests that use Blink frontend to test display
 methods and savefig routines

---
 src/PlotlyJS.jl          |   2 +-
 src/displays/electron.jl |   2 +-
 test/REQUIRE             |   1 +
 test/blink.jl            | 118 +++++++++++++++++++++++++++++++++++++++
 test/runtests.jl         |   3 +
 5 files changed, 124 insertions(+), 2 deletions(-)
 create mode 100644 test/blink.jl

diff --git a/src/PlotlyJS.jl b/src/PlotlyJS.jl
index 94e37519..d467d198 100644
--- a/src/PlotlyJS.jl
+++ b/src/PlotlyJS.jl
@@ -12,7 +12,7 @@ import PlotlyBase:
     restyle!, relayout!, update!, addtraces!, deletetraces!, movetraces!,
     redraw!, extendtraces!, prependtraces!, purge!, to_image, download_image,
     restyle, relayout, update, addtraces, deletetraces, movetraces, redraw,
-    extendtraces, prependtraces, prep_kwargs, sizes, savefig
+    extendtraces, prependtraces, prep_kwargs, sizes, savefig, _tovec
 
 using Blink
 using Requires
diff --git a/src/displays/electron.jl b/src/displays/electron.jl
index 400809c6..cfec47a6 100644
--- a/src/displays/electron.jl
+++ b/src/displays/electron.jl
@@ -293,7 +293,7 @@ function redraw!(p::ElectronDisplay)
 end
 
 function purge!(p::ElectronDisplay)
-    @js_ p begin reset_svg(); Plotly.purge(this).then(save_svg) end
+    @js_ p begin reset_svg(); Plotly.purge(this) end
 end
 
 function to_image(p::ElectronDisplay; kwargs...)
diff --git a/test/REQUIRE b/test/REQUIRE
index 4f9291d8..73a29362 100644
--- a/test/REQUIRE
+++ b/test/REQUIRE
@@ -1 +1,2 @@
 TestSetExtensions 1.0
+Rsvg 0.2
diff --git a/test/blink.jl b/test/blink.jl
new file mode 100644
index 00000000..a91218da
--- /dev/null
+++ b/test/blink.jl
@@ -0,0 +1,118 @@
+using Blink
+
+p = plot(rand(10, 4))
+display(p)
+w = PlotlyJS.get_window(p)
+sleep(1.0)  # make sure we give time for svg to render
+
+# test that plotly loads
+@test isa(@js(p, Plotly), Dict)
+
+# test that svg is defined
+@test isa(@js(p, $(PlotlyJS.svg_var(p))), String)
+
+# test that we get back reasonable svg
+svg = @js(p, $(PlotlyJS.svg_var(p)))
+@test svg[1:4] == "<svg"
+@test svg[end-5:end] == "</svg>"
+
+@testset "api methods" begin
+
+    @testset "to_image" begin
+        @test to_image(p)[1:21] == "data:image/png;base64"
+        @test to_image(p, format="svg")[1:18] == "data:image/svg+xml"
+        @test to_image(p, format="jpeg")[1:22] =="data:image/jpeg;base64"
+        @test to_image(p, format="webp")[1:22] =="data:image/webp;base64"
+        @test_throws Blink.JSError to_image(p, format="pdf")
+        @test to_image(p, imageDataOnly=true, format="svg")[1:4] == "<svg"
+    end
+
+    @testset "restyle" begin
+        restyle!(p, marker_color="pink", 1)
+        @test @js(p, gd.data[0].marker.color) == "pink"
+
+        restyle!(p, marker_symbol="star")
+        @test @js(p, gd.data[0].marker.symbol) == "star"
+        @test @js(p, gd.data[1].marker.symbol) == "star"
+        @test @js(p, gd.data[2].marker.symbol) == "star"
+        @test @js(p, gd.data[3].marker.symbol) == "star"
+    end
+
+    @testset "relayout" begin
+        relayout!(p, title="This is a title")
+        @test @js(p, gd.layout.title) == "This is a title"
+    end
+
+    @testset "update" begin
+        update!(p, marker_size=10, layout=Layout(xaxis_title="This is x"))
+        @test @js(p, gd.data[0].marker.size) == 10
+        @test @js(p, gd.data[1].marker.size) == 10
+        @test @js(p, gd.data[2].marker.size) == 10
+        @test @js(p, gd.data[3].marker.size) == 10
+        @test @js(p, gd.layout.xaxis.title) == "This is x"
+    end
+
+    @testset "addtraces" begin
+        @test @js(p, gd.data.length) == 4
+        new_trace = scatter(x=1:10, y=(1:10.0).^2, name="New trace")
+        addtraces!(p, new_trace)
+        @test @js(p, gd.data.length) == 5
+        @test all(@js(p, gd.data[4].x) .== 1:10)
+        @test all(@js(p, gd.data[4].y) .== (1:10).^2)
+        @test @js(p, gd.data[4].name) == "New trace"
+    end
+
+    @testset "movetraces" begin
+        @test @js(p, gd.data[4].name) == "New trace"
+        movetraces!(p, [5, 4], [4, 5])
+        @test @js(p, gd.data[3].name) == "New trace"
+    end
+
+    @testset "deletetraces" begin
+        @test @js(p, gd.data.length) == 5
+        deletetraces!(p, 4)
+        @test @js(p, gd.data.length) == 4
+        @test @js(p, gd.data[3].name) === nothing
+    end
+
+    @testset "extendtraces" begin
+        extendtraces!(p.view, 1, -1; y=[2, 2.5, 3.0])
+        @test @js(p, gd.data[0].y.length) == 13
+        @test all(@js(p, gd.data[0].y)[end-2:end] .== [2, 2.5, 3.0])
+    end
+
+    @testset "prependtraces" begin
+        prependtraces!(p.view, 1, -1; y=[3, 4, 5])
+        @test @js(p, gd.data[0].y.length) == 16
+        @test all(@js(p, gd.data[0].y)[1:3] .== [3, 4, 5])
+    end
+
+    @testset "purge" begin
+        purge!(p)
+        @test @js(p, gd.data) === nothing
+    end
+end
+
+using Rsvg
+
+@testset "savefig" begin
+    my_dir = tempdir()
+    p = plot(rand(10, 4))
+    display(p)
+    sleep(4)  # give it _plently_ of time to render
+    for extension in [".plotly.json", "json", "html", "svg", "pdf", "png", "eps"]
+        fn = joinpath(my_dir, "out.$(extension)")
+        @test begin
+            savefig(p, fn)
+            isfile(fn)
+        end
+    end
+
+    # also try method where we open non-visible window
+    p = plot(rand(10, 4))
+    for extension in [".plotly.json", "json", "html", "svg", "pdf", "png", "eps"]
+        fn = joinpath(my_dir, "out.$(extension)")
+        savefig(p, fn)
+        @test isfile(fn)
+    end
+end
diff --git a/test/runtests.jl b/test/runtests.jl
index 529dca4e..5dca1d94 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -6,6 +6,9 @@ using Base.Test
 using PlotlyJS
 const M = PlotlyJS
 
+using Blink
+!Blink.AtomShell.isinstalled() && Blink.AtomShell.install()
+
 try
     @testset ExtendedTestSet "PlotlyJS Tests" begin
         @includetests ARGS