Implement various progress modes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
Mar 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 61.23% 64.49% +3.26%
==========================================
Files 6 7 +1
Lines 632 738 +106
==========================================
+ Hits 387 476 +89
- Misses 245 262 +17
Continue to review full report at Codecov.
|
In order to reliably and timely make progress within UCX the user is responsible for occasionally call `progess` on the UCX worker. Originally I used a Julia `Timer` object to gurantee progress especially in the context of asymmetric communication, e.g. active messages. The `Timer` object would trigger ever millisecond resulting in a much higher latency, following that I implemented the polling interface using the WAKEUP feature, but that turns of support for shared memory openucx/ucx#5322 and turned out to have relativly high overhead in a pure latency test on the order of ~20microseconds. I experimented with two other modes (1) the busy waiting mode, but that is using unfair scheduling and might livelock and libuv `Idle`. Idle callbacks are a bit odd, but seem to work well everytime Julia ticks the event loop libuv will call the progress function. The performanc of busy waiting seems to degrade with multiple threads, while the idler performs well, but I have not yet performed a whole system comparision.
vchuravy
force-pushed
the
vc/polling_test
branch
from
568d1cc to
f6d1c47
Compare
This was referenced Mar 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.