Set JULIA_BINDIR when running mpiexecjl tests
#858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/fix-mpiexecjl
branch
2 times, most recently
from
f617bb5
to
2709d8e
Compare
giordano
force-pushed
the
mg/fix-mpiexecjl
branch
from
2709d8e
to
e6f6c89
Compare
giordano
commented
Aug 6, 2024
Comment on lines
-18
to
+19
| mpiexecjl = joinpath(dir, "mpiexecjl") | ||
| env = ["JULIA_BINDIR" => Sys.BINDIR] | ||
| mpiexecjl = addenv(`$(joinpath(dir, "mpiexecjl"))`, env...) |
There was a problem hiding this comment.
I'm still not sure about why JULIA_BINDIR is needed, but I think that ensuring mpiexecjl is consistently called with the same environment in all these tests is a good change: it's less error-prone as it avoids missing something in possible future tests. As a side effect, we can slightly simplify the code in these tests whenever we call mpiexecjl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a good explanation of why this is necessary, but setting
JULIA_BINDIR, as it was done in #481 for the other run in the same test set, fixes #857 for me. My only hypothesis is that this somehow helps Julia find its own libraries, perhaps especially if using juliaup, but honestly I can't tell what's failing without settingJULIA_BINDIR. Also, note that that I don't have problems usingmpiexecjlnormally, the issue reported in #857 appeared only when running the tests.