Rework LLVMExtra using augmented platforms. #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
tb/llvmextra_platform
branch
2 times, most recently
from
fda5f17
to
fe32c7b
Compare
vchuravy
reviewed
Jan 20, 2022
vchuravy
reviewed
Jan 20, 2022
maleadt
force-pushed
the
tb/llvmextra_platform
branch
3 times, most recently
from
f53ae82
to
e8b5152
Compare
maleadt
force-pushed
the
tb/llvmextra_platform
branch
from
e8b5152
to
e3a4c37
Compare
vchuravy
approved these changes
Feb 23, 2022
This was referenced Feb 23, 2022
|
Side note, but we need to find a more sustainable way to build for multiple platforms. Azure Pipelines can spawn at most 256 jobs, here we had already 178 |
|
For the record, you can run the workflow https://github.com/JuliaPackaging/Yggdrasil/actions/workflows/update_manifest.yml to automatically open a pr which updates the manifest also providing a link to the diff of the changes in BinaryBuilder, see for example #4489 |
vchuravy
force-pushed
the
tb/llvmextra_platform
branch
from
660e9ed
to
c714104
Compare
giordano
reviewed
Mar 22, 2022
| const platform_name = "llvm_version" | ||
| const augment = """ | ||
| function augment_llvm!(platform::Platform) | ||
| haskey(platform, "llvm_version") && return p |
There was a problem hiding this comment.
I presume this was supposed to be
haskey(platform, "llvm_version") && return platform?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #4291, but for LLVMExtra.