Support augment_platform in BB #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
previously requested changes
Dec 16, 2021
giordano
reviewed
Dec 17, 2021
giordano
force-pushed
the
vc/augmented_platform
branch
from
7e323af
to
9623571
Compare
giordano
reviewed
Dec 17, 2021
giordano
force-pushed
the
vc/augmented_platform
branch
from
cb5242a
to
78eb506
Compare
vchuravy
force-pushed
the
vc/augmented_platform
branch
from
78eb506
to
97c5ea7
Compare
vchuravy
force-pushed
the
vc/augmented_platform
branch
from
97c5ea7
to
9a79943
Compare
vchuravy
force-pushed
the
vc/augmented_platform
branch
from
9a79943
to
42c559c
Compare
vchuravy
force-pushed
the
vc/augmented_platform
branch
from
42c559c
to
5a0d1a4
Compare
vchuravy
force-pushed
the
vc/augmented_platform
branch
from
5a0d1a4
to
35cc5b6
Compare
giordano
reviewed
Jan 4, 2022
vchuravy
force-pushed
the
vc/augmented_platform
branch
from
35cc5b6
to
e15eb9c
Compare
maleadt
force-pushed
the
vc/augmented_platform
branch
from
e15eb9c
to
c41d1c1
Compare
giordano
reviewed
Jan 20, 2022
giordano
previously requested changes
Jan 20, 2022
Co-authored-by: Tim Besard <[email protected]>
maleadt
force-pushed
the
vc/augmented_platform
branch
from
84e5dbb
to
7de64e1
Compare
|
Rebased and addressed review comments. I'd like to use this for JuliaPackaging/Yggdrasil#4292, which in turn will unblock some work on LLVM.jl (handling assertion builds). |
|
JuliaPackaging/Yggdrasil#4292 has passed CI, so this looks good to go (unless there's further review comments, of course). |
|
Thanks Tim! |
Co-authored-by: Mosè Giordano <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Mar 24, 2022
443: Allow TOML as dependency of JLL packages r=DilumAluthge a=giordano Since JuliaPackaging/BinaryBuilder.jl#1128 we also use TOML for JLLs in some cases. Co-authored-by: Mosè Giordano <[email protected]>
bors bot
added a commit
to JuliaRegistries/RegistryCI.jl
that referenced
this pull request
Apr 6, 2022
443: Allow TOML as dependency of JLL packages r=DilumAluthge a=giordano Since JuliaPackaging/BinaryBuilder.jl#1128 we also use TOML for JLLs in some cases. Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to JuliaPackaging/JLLWrappers.jl#35