Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fictional UUID created for non JLL package #1132

Closed
vchuravy opened this issue Dec 17, 2021 · 1 comment · Fixed by #1133
Closed

Fictional UUID created for non JLL package #1132

vchuravy opened this issue Dec 17, 2021 · 1 comment · Fixed by #1133

Comments

@vchuravy
Copy link
Member

In a local version of JuliaPackaging/Yggdrasil#4073 I am experimenting with adding a non jll dependency.
Thanks to @giordano who pointed me to the right place. We should look up the UUID instead of synthesizing a new one.

project["deps"][depname] = string(jll_uuid(depname))

cc: @staticfloat

@staticfloat
Copy link
Member

Heh, yeah. This is making use of the fact that JLLs all have deterministic UUIDs; so if you've got two different BBs generating JLLs that don't exist in the registry yet, they generate consistent UUIDs, etc...

But you're right, we should do a lookup in the registry first, and only do the hashing thing if it doesn't already have a match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants