Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore allocation free maxdiff #1051

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

annuges
Copy link
Contributor

@annuges annuges commented Oct 5, 2023

The maxdiff function used in assess_convergence allocates which causes a non negligible time increase in a large-ish LBFGS problem for me.

#889 switched maxdiff to a mapreduce based implementation to support gpu arrays.
Unfortunately the mapreduce now allocates for standard arrays.

This change restores the previous allocation free code for normal Arrays while still allowing gpu arrays using mapreduce

The mapreduce based version allocates which is undesirable.
This change restores the previous allocation free code for normal Arrays while still allowing gpu arrays using mapreduce
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #1051 (2cdc4f8) into master (5fa5d61) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 2cdc4f8 differs from pull request most recent head 332cc29. Consider uploading reports for the commit 332cc29 to get more accurate results

@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage   85.29%   85.32%   +0.03%     
==========================================
  Files          43       43              
  Lines        3216     3224       +8     
==========================================
+ Hits         2743     2751       +8     
  Misses        473      473              
Files Coverage Δ
src/utilities/maxdiff.jl 100.00% <100.00%> (ø)

@pkofod pkofod merged commit 7fbfb36 into JuliaNLSolvers:master Oct 7, 2023
6 checks passed
@pkofod
Copy link
Member

pkofod commented Oct 7, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants