Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why aref_calls, df_calls and h_calls all Vector{Int}? #151

Open
junyuan-chen opened this issue Mar 27, 2023 · 1 comment
Open

Why aref_calls, df_calls and h_calls all Vector{Int}? #151

junyuan-chen opened this issue Mar 27, 2023 · 1 comment

Comments

@junyuan-chen
Copy link

It seems strange to me that these fields are Vector{Int} when the objective types (OnceDifferentiable etc.) are already mutable. Is there any use case where a vector is needed to hold multiple values? Would having these fields as Int be sufficient?

Also, the way to set/retrieve these counters are not explicitly made into the interface. But, there could be some functions defined just for that so that external packages do not have to hardcode the field names.

@pkofod
Copy link
Member

pkofod commented Oct 8, 2023

I don't think it's necessary, no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants