Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using other array types in TwiceOrderDifferentiable finite differences #139

Closed
longemen3000 opened this issue Jun 4, 2021 · 3 comments · Fixed by #140
Closed

allow using other array types in TwiceOrderDifferentiable finite differences #139

longemen3000 opened this issue Jun 4, 2021 · 3 comments · Fixed by #140

Comments

@longemen3000
Copy link
Contributor

xref JuliaNLSolvers/Optim.jl#924

@amrods
Copy link
Contributor

amrods commented Jun 6, 2021

Is this as easy as changing Vector to AbstractVector and Matrix to AbstractMatrix in

function fg!(storage::Vector, x::Vector)
and
function h!(storage::Matrix, x::Vector)
? If so, I can make that PR. I am needing that relatively quickly.

@longemen3000
Copy link
Contributor Author

Yes, it's only that. If you need it right know without waiting for a PR, you can write a junction yourself that does what the Twicedifferentiable.jl constructor do

@amrods
Copy link
Contributor

amrods commented Jun 6, 2021

I'll do that in my fork directly, but I won't make a PR. I don't want to usurp it from you. I am afraid of messing up my packages though. I suppose I can remove the "official" version and instead install my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants