Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonexistent overload of Printf functionality #40

Closed
Seelengrab opened this issue Jun 3, 2022 · 1 comment · Fixed by #58
Closed

Fix nonexistent overload of Printf functionality #40

Seelengrab opened this issue Jun 3, 2022 · 1 comment · Fixed by #58

Comments

@Seelengrab
Copy link

else
fix_dec(out, d::BFloat16, flags::String, width::Int, precision::Int, c::Char, digits) = fix_dec(out, Float32(d), flags, width, precision, c, digits)
ini_dec(out, d::BFloat16, ndigits::Int, flags::String, width::Int, precision::Int, c::Char, digits) = ini_dec(out, Float32(d), ndigits, flags, width, precision, c, digits)
ini_hex(out, d::BFloat16, ndigits::Int, flags::String, width::Int, precision::Int, c::Char, digits) = ini_hex(out, Float32(d), ndigits, flags, width, precision, c, digits)
ini_HEX(out, d::BFloat16, ndigits::Int, flags::String, width::Int, precision::Int, c::Char, digits) = ini_HEX(out, Float32(d), ndigits, flags, width, precision, c, digits)
ini_hex(out, d::BFloat16, flags::String, width::Int, precision::Int, c::Char, digits) = ini_hex(out, Float32(d), flags, width, precision, c, digits)
ini_HEX(out, d::BFloat16, flags::String, width::Int, precision::Int, c::Char, digits) = ini_HEX(out, Float32(d), flags, width, precision, c, digits)
end

These lines should probably be replaced with functions from Base.Ryu. I think this has been broken since at least 1.6.

@JeffreySarnoff
Copy link
Member

happy to do so -- no idea what to do though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants