Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the manifold of symmetric positive definite matrices with two metrics #27

Merged
merged 50 commits into from
Nov 25, 2019
Merged

Introduce the manifold of symmetric positive definite matrices with two metrics #27

merged 50 commits into from
Nov 25, 2019

Commits on Jul 5, 2019

  1. transfers the formulae for spds.

    @kellertuer
    kellertuer committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    f601b5f View commit details
    Browse the repository at this point in the history

  2. extends vector transport, renames the manifold (corrects a typo) and … 

    …transfers parallel transport.
    @kellertuer
    kellertuer committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    4705d88 View commit details
    Browse the repository at this point in the history

  3. adopts Project.toml

    @kellertuer
    kellertuer committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    99e80f3 View commit details
    Browse the repository at this point in the history

  4. removes traitsimpl, fixes a few typos.

    @kellertuer
    kellertuer committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    ec3a960 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2019

  1. fixes several things mentioned in the comments, updates documentation… 

    … for LinearAffine functions.
    @kellertuer
    kellertuer committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    bf3bab3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into SymmetricPositiveDefinite

    @kellertuer
    kellertuer committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    f999bc7 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. starts documentation.

    @kellertuer
    kellertuer committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    b90fef3 View commit details
    Browse the repository at this point in the history

  2. starts testing.

    @kellertuer
    kellertuer committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    64c851a View commit details
    Browse the repository at this point in the history

  3. imroves optimization and fixes tests.

    @kellertuer
    kellertuer committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    d5b98a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2019

  1. adds a method to compute an ONB in TxM.

    @kellertuer
    kellertuer committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    368c59b View commit details
    Browse the repository at this point in the history

  2. adds a distance for log-euclidean.

    @kellertuer
    kellertuer committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    a3eef00 View commit details
    Browse the repository at this point in the history

  3. fixes a typo.

    @kellertuer
    kellertuer committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    55b3574 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Merge branch 'master' into SymmetricPositiveDefinite 

    * master: (46 commits)
  Fix variable name
  Skip unstable test on 32-bit windows
  Improve rotations documentation
  Use quadratic notation for clarity
  Limit vee and hat to Rotations for now
  Clarify documentation of vee and hat
  Use a clearer notation for SO(4)
  Add explicit exp for SO(4)
  Add edge cases for SO(4)
  Add custom norm
  Bypass slow StaticArray exp on Julia 1.0
  Determine if SO(5) exponential is the culprit
  Determine if SO(4) exponential is the culprit
  Determine if SO(3) exponential is the culprit
  Remove norm to see if it stall the build
  Re-enable exp
  Re-disable half of failing test
  Re-enable last tests
  Make test less stringent
  Re-enable log edge cases
  ...
    @kellertuer
    kellertuer committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    61f24e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Merge branch 'master' into SymmetricPositiveDefinite

    @kellertuer
    kellertuer committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    c93134c View commit details
    Browse the repository at this point in the history

  2. refactor vector_trasnports to include a method, finish rework of SPD … 

    …functions.
    @kellertuer
    kellertuer committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    af58cca View commit details
    Browse the repository at this point in the history

  3. unifies all vector_transport_to!s to the same default such that tests… 

    … now again work.
    @kellertuer
    kellertuer committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    0626111 View commit details
    Browse the repository at this point in the history

  4. adds a test for vector_transport and increases tolerance for 32bit SPDs.

    @kellertuer
    kellertuer committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    7532a54 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. finishes remarks from Mateusz.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d27ff87 View commit details
    Browse the repository at this point in the history

  2. increase test coverage and work on style and minor errors encountered… 

    … by Mateusz.
    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    6a10755 View commit details
    Browse the repository at this point in the history

  3. towards more tests.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7f0447a View commit details
    Browse the repository at this point in the history

  4. removes two further too ambiguous definitions I oversaw.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    fd95a2f View commit details
    Browse the repository at this point in the history

  5. Rearrange code, finds the previous bug, a missing comma.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    737bd32 View commit details
    Browse the repository at this point in the history

  6. fixes tests and adopt equality setting of vector_transport.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    e625630 View commit details
    Browse the repository at this point in the history

  7. improve equality check further.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7822bda View commit details
    Browse the repository at this point in the history

  8. Collect all documentations of SPD, as far as these functions are impl… 

    …emented.
    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    6768930 View commit details
    Browse the repository at this point in the history

  9. Extends and documents Euclidean.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    f25165f View commit details
    Browse the repository at this point in the history

  10. removes a spurius project skeleton that appeared due to a typo.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    a5e59ab View commit details
    Browse the repository at this point in the history

  11. corrects a few typos.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    5188733 View commit details
    Browse the repository at this point in the history

  12. Fixes a bug I introduced when cleaning the code.

    @kellertuer
    kellertuer committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    5879750 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2019

  1. Introduces the CholeskySpace manifold to easily build a second (the… 

    … `LogCholesky`) metric on `SymmetricPositiveDefinite`.
    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    3a6bea5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into SymmetricPositiveDefinite to resolve the m… 

    …erge conflicts

#	Project.toml
#	src/Manifolds.jl
    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    039fe95 View commit details
    Browse the repository at this point in the history

  3. Minor changes and first bugfixes.

    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    97bdf17 View commit details
    Browse the repository at this point in the history

  4. add tests for CholeskySpace, removes basic manifolds tests since they… 

    … are covered by ManifoldsBase in the future.
    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    c9c3b30 View commit details
    Browse the repository at this point in the history

  5. fixes a function helper in naming and fixes lower triangulars to be t… 

    …he strict versions.
    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    70cf1bc View commit details
    Browse the repository at this point in the history

  6. adds a vector transport to CholeskySpace.

    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    c2784cc View commit details
    Browse the repository at this point in the history

  7. Works on the tests for SPD with two metrics.

    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    7efacad View commit details
    Browse the repository at this point in the history

  8. adds a testset per metric with nice output per metric. Still does not… 

    … work with the `hasMetric` trait.
    @kellertuer
    kellertuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    258e6e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2019

  1. Rename trait to DefaultMetric, still the nonDefaults ones error (st… 

    …arting with log since thats the first error).
    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    5791fcb View commit details
    Browse the repository at this point in the history

  2. update tests.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    c7a17d2 View commit details
    Browse the repository at this point in the history

  3. fixes the bugs simletraits introduces for nondefault types.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    1427d72 View commit details
    Browse the repository at this point in the history

  4. finishes testing and adds documentation.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    dbd0c07 View commit details
    Browse the repository at this point in the history

  5. Simplifies MetricManifold to work without simpleTraits.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    7def9e1 View commit details
    Browse the repository at this point in the history

  6. Work on further stuff where metric still breaks.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    a4ec17f View commit details
    Browse the repository at this point in the history

  7. introduces a few improvements from code review.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    38cae37 View commit details
    Browse the repository at this point in the history

  8. Optimize SPD further.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    3ba1c32 View commit details
    Browse the repository at this point in the history

  9. Minor further improvements, fixes all tests again.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    3cb1b02 View commit details
    Browse the repository at this point in the history

  10. adds a final optimization remark.

    @kellertuer
    kellertuer committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    dcfd9a2 View commit details
    Browse the repository at this point in the history

  11. SPD manifold enabled on MMatrix{3,3,Float32}

    @mateuszbaran
    mateuszbaran committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    e23be3b View commit details
    Browse the repository at this point in the history

  12. merge

    @mateuszbaran
    mateuszbaran committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    2afeaab View commit details
    Browse the repository at this point in the history

  13. disabling tests for SPD - MMatrix - LogCholeskyMetric combination

    @mateuszbaran
    mateuszbaran committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    7af42cf View commit details
    Browse the repository at this point in the history