Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove n==1 special cases in exp.jl? #83

Closed
stevengj opened this issue Aug 20, 2022 · 1 comment
Closed

remove n==1 special cases in exp.jl? #83

stevengj opened this issue Aug 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@stevengj
Copy link
Member

I don't really understand why you need n==1 special cases. If eigen! doesn't give the right answer when n==1, it should be fixed.

(Yes, you can make the n==1 case faster by special-casing it, but this complicates the code to add a performance optimization no one really cares about — if they really wanted to be fast for n==1 they would be using scalars.)
@stevengj stevengj added the enhancement New feature or request label Aug 20, 2022
@smataigne
Copy link
Collaborator

I don't really understand why you need n==1 special cases. If eigen! doesn't give the right answer when n==1, it should be fixed.

(Yes, you can make the n==1 case faster by special-casing it, but this complicates the code to add a performance optimization no one really cares about — if they really wanted to be fast for n==1 they would be using scalars.)

This is corrected and special cases n==1 have been removed from exp.jl. I will close the issue when I will have pushed the updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevengj @smataigne